Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check large objects before replication #2558

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Check large objects before replication #2558

merged 1 commit into from
Oct 29, 2024

Conversation

KillianG
Copy link
Contributor

Issue: BB-566

@bert-e
Copy link
Contributor

bert-e commented Oct 15, 2024

Hello killiang,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Oct 15, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.77%. Comparing base (31d9ca6) to head (f74d084).
Report is 48 commits behind head on development/8.7.

Files with missing lines Patch % Lines
extensions/replication/tasks/ReplicateObject.js 81.48% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
...tensions/replication/ReplicationConfigValidator.js 60.00% <ø> (ø)
extensions/replication/tasks/ReplicateObject.js 91.49% <81.48%> (-0.87%) ⬇️

... and 6 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 66.66% <ø> (ø)
Core Library 74.12% <ø> (-0.02%) ⬇️
Ingestion 69.24% <ø> (ø)
Lifecycle 75.83% <ø> (ø)
Oplog Populator 82.95% <ø> (ø)
Replication 57.67% <81.48%> (+0.25%) ⬆️
Bucket Scanner 85.60% <ø> (-0.16%) ⬇️ 
@@                 Coverage Diff                 @@
##           development/8.7    #2558      +/-   ##
===================================================
+ Coverage            69.67%   69.77%   +0.10%     
===================================================
  Files                  194      194              
  Lines                12819    12919     +100     
===================================================
+ Hits                  8931     9014      +83     
- Misses                3878     3895      +17     
  Partials                10       10
Flag Coverage Δ
api:retry 9.61% <0.00%> (-0.03%) ⬇️
api:routes 9.51% <0.00%> (-0.03%) ⬇️
bucket-scanner 85.60% <ø> (-0.16%) ⬇️
ingestion 12.45% <0.00%> (-0.03%) ⬇️
lib 7.51% <0.00%> (-0.03%) ⬇️
lifecycle 19.29% <0.00%> (-0.05%) ⬇️
notification 0.88% <0.00%> (-0.01%) ⬇️
replication 19.05% <81.48%> (+0.13%) ⬆️
unit 44.50% <7.40%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@bert-e
Copy link
Contributor

bert-e commented Oct 15, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@KillianG KillianG force-pushed the improvement/BB-566-avoid-infinite-replication branch 2 times, most recently from a458861 to e4f5d49 Compare October 17, 2024 17:21
@KillianG KillianG force-pushed the improvement/BB-566-avoid-infinite-replication branch from e4f5d49 to ae001e3 Compare October 18, 2024 13:43
@KillianG KillianG force-pushed the improvement/BB-566-avoid-infinite-replication branch from 2e75276 to 54216a6 Compare October 25, 2024 12:53
@KillianG KillianG requested a review from Kerkesni October 25, 2024 13:23
@KillianG KillianG force-pushed the improvement/BB-566-avoid-infinite-replication branch from 54216a6 to f74d084 Compare October 25, 2024 13:24
@KillianG KillianG requested a review from benzekrimaha October 29, 2024 09:44
@KillianG
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Oct 29, 2024

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 29, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

Please check the status of the associated issue BB-566.

Goodbye killiang.

@bert-e bert-e merged commit 6694ca8 into development/8.7 Oct 29, 2024
9 checks passed
@bert-e bert-e deleted the improvement/BB-566-avoid-infinite-replication branch October 29, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benzekrimaha benzekrimaha benzekrimaha approved these changes

@Kerkesni Kerkesni Kerkesni approved these changes

@francoisferrand francoisferrand Awaiting requested review from francoisferrand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KillianG @bert-e @francoisferrand @Kerkesni @benzekrimaha